Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add public doc for enabled_by_type & enabled_by_value #810

Closed
wants to merge 11 commits into from
Closed

Add public doc for enabled_by_type & enabled_by_value #810

wants to merge 11 commits into from

Conversation

chenslucky
Copy link
Contributor

Description

Add public doc for enabled_by_type & enabled_by_value

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@chenslucky chenslucky requested a review from a team as a code owner October 18, 2023 08:29
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 18, 2023
dorisjoy
dorisjoy reviewed Oct 23, 2023
View reviewed changes
docs/how-to-guides/develop-a-tool/how-to-use-enabled-by.md

@tool
def embedding(connection: Enum, input: str, deployment_name: str = "", model: EmbeddingModel = EmbeddingModel.TEXT_EMBEDDING_ADA_002):
connection_dict = dict(connection)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If connection is a str Enum, how it can be used as a dict to send an API call ?

@chenslucky chenslucky closed this Oct 27, 2023
@chenslucky chenslucky deleted the chesi/add-enable-by-doc branch April 10, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorisjoy dorisjoy dorisjoy left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenslucky @dorisjoy